Fix severity classification and agent scope from RI CCAP lessons

[hua7450]

Summary

Fixes multiple pipeline issues discovered during the RI CCAP implementation session where correct findings were under-classified and agents exceeded their scope.

Root Causes Addressed

1. Severity classification gaps

The review pipeline correctly identified issues but classified them below CRITICAL, so the fix round skipped them:

• Wrong section citations (e.g., 4.3.1(B) → 4.3.1(A)(4)) classified as medium
• Hard-coded age values (1.5, 3, 6) classified as moderate
• Untested complex formula variables classified as SHOULD ADDRESS
• Non-functional tests (absolute_error_margin: 1 on booleans) classified as minor

2. Agent scope violations

• Parameter-architect created variables and tests (not its job)
• Orchestrator skipped rules-engineer and test-creator because files already existed
• Result: lower-quality variables (bare input enums) and tests (wrong error margins, mismatched member counts)

3. Missing verification steps

• Consolidator didn't verify citations against PDF text before writing impl-spec
• Reference-checker proposed replacement citations without verifying them
• No agent discovered existing reusable variables (e.g., childcare_hours_per_week)

Changes (10 files, 175 insertions)

Skills (shared knowledge — all agents inherit)

• policyengine-parameter-patterns-skill — "Above X%" bracket boundary pattern (0.0001 shift)
• policyengine-testing-patterns-skill — Type-specific error margins (none for booleans, 0.01 for currency); don't exhaustively test lookup tables
• policyengine-variable-patterns-skill — Enum variables with numeric-range labels must have formulas using bracket parameters

Agents

• reference-validator — Wrong section citations → CRITICAL; verify replacement citations against PDF text
• implementation-validator — Hard-coded values labeled CRITICAL in report template; empty directory cleanup
• parameter-architect — Explicit scope boundary: parameter YAML files ONLY
• edge-case-generator — Bracket boundary consistency; representative testing not exhaustive
• test-creator — Don't exhaustively test lookup tables

Commands

• encode-policy-v2 — Consolidator verifies citations (Step 3) and discovers existing variables (Step 2); reporter includes Historical Notes; orchestrator always spawns rules-engineer + test-creator
• review-program — Consolidator CRITICAL list expanded: incorrect section citations, untested formula variables, non-functional tests

🤖 Generated with Claude Code