-
Notifications
You must be signed in to change notification settings - Fork 3
Add docker compose support, make documentation #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anth-volk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @pkarman! One minor change suggested. Otherwise, this should be good to go, but would appreciate if you wouldn't also mind updating the documentation at config/README.md to describe how a user might set the specified environment variables within a Docker compose-driven workflow.
docker/start.sh
Outdated
| # Start multiple workers using POSIX-compliant loop | ||
| # TODO worker.py does not seem to exist? | ||
| #i=1 | ||
| #while [ $i -le "$WORKER_COUNT" ] | ||
| #do | ||
| # echo "Starting worker $i..." | ||
| # python3 policyengine_api/worker.py & | ||
| # i=$((i + 1)) | ||
| #done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: You should be able to remove this. This API doesn't use workers at all and never has, that's only our internal REST API.
Sure thing. I added a note to The tl;dr is: config works much the same way, with the added convenience of creating a local |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
@pkarman apologies for the radio silence on this, I lost track of it over the holidays. I've added a couple minor changes and also opened a new PR at #1185, as the testing flow we use requires tokens that unfortunately can't be shared via forks. I'm going to close this PR, then get the new one over the line. Thanks for all of your contributions on this. |
Purpose
These changes add Docker Compose support to allow for local development consistent with the deployed environment. In theory, this would allow for deployment into alternate cloud platforms.
Changes
MakefilemaketargetsDockerfile.apianddocker-compose.ymlSee also
MyFriendBen/benefits-api#1216