Fix dataset uprating and salary sacrifice default behavior #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix dataset uprating bug where region values weren't converted to strings for rent indexing - Change salary sacrifice default behavior to be static (0) instead of fully optimized (1.0) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Dataset Uprating Bug (policyengine_uk/data/economic_assumptions.py:165)
Problem: Regional rent uprating was failing because region values weren't being converted to strings before indexing into the private rental prices parameter.
Impact: Dataset uprating for rent values was breaking for years 2022-2024.
Fix: Convert
region.valuestoregion.values.astype(str)before indexing.Salary Sacrifice Default Behavior
Problem: The
employee_salary_sacrifice_reduction_rateparameter had a default value of1.0(full optimization), but the default behavior should be static (no behavioral response).Impact: Simulations were incorrectly assuming employees would fully optimize their salary sacrifice in response to caps.
Fix: Change default value from
1.0to0to make behavior static by default.Test plan
🤖 Generated with Claude Code