Changing to auto loan interest imputation #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
In this version the cps does not have a "auto_loan_balance" variable anymore as we impute "auto_loan_interest" directly. If we want to have both I can add an imputation for balance as well. |
MaxGhenis
reviewed
May 19, 2025
MaxGhenis
requested changes
May 19, 2025
MaxGhenis
requested changes
May 20, 2025
nikhilwoodruff
approved these changes
May 21, 2025
Contributor
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
Good to merge after adding back in auto loan balance to the imputation list while we're here.
nikhilwoodruff
approved these changes
May 22, 2025
Contributor
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
Actually we don't need to hold this up for the loan balance since that (may) need microimpute changes. Good to merge.
juaristi22
added a commit
that referenced
this pull request
May 23, 2025
* changing to auto loan interest imputation * move 100 * auto loan variables in scf.py * division by 100 for loan rate comments * changing test to use upper and lower bounds * around 270 * testing logging level and auto loan test * trying with 100_000 * fixed auto loan interest values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #216