Fix dataset upload to warn instead of fail on missing files #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the upload process to continue with available files rather than failing completely when any dataset file is missing. This allows successful deployment while making missing files visible through warning messages, preventing the silent omission of datasets like the pooled 3-year CPS. Fixes #415
juaristi22
pushed a commit
that referenced
this pull request
Aug 8, 2025
* Fix dataset upload to warn instead of fail on missing files Changes the upload process to continue with available files rather than failing completely when any dataset file is missing. This allows successful deployment while making missing files visible through warning messages, preventing the silent omission of datasets like the pooled 3-year CPS. Fixes #415 * Error instead of warning * Fix bug causing test lite to be true * Versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataset upload was failing silently when files were missing, so available datasets weren't getting deployed. This changes the upload script to warn about missing files but continue with the ones that exist.
The pooled CPS wasn't being published because of a bug in policyengine_us_data/datasets/cps/cps.py:19. The original
test_lite = os.environ.get("TEST_LITE")would return the string "false" whenTEST_LITE=false, which is truthy in Python. So test lite mode was always enabled, preventing full dataset generation. Fixed this in commit 909c912.Fixes #415