-
Notifications
You must be signed in to change notification settings - Fork 204
QBID variables only #6031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
QBID variables only #6031
Changes from 17 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0becdc4
qbid income definition
baogorek 04e3c02
new formulas
baogorek 2728f39
Split input income variables into separate files
baogorek 2ab3fd8
Merge pull request #6047 from PolicyEngine/codex/separate-variable-cl…
baogorek 956077e
renaming. new qbid formulas
baogorek 2d64d19
Merge branch 'master' of github.com:PolicyEngine/policyengine-us into…
baogorek 6680a82
adding one unit test
PavelMakarchuk c319360
Refine QBI deduction references
baogorek 5960e75
Merge pull request #6050 from PolicyEngine/codex/add-tax-code-referen…
baogorek 1383eb3
Document tax form references for QBID
baogorek 57edd94
Merge pull request #6052 from PolicyEngine/codex/add-comments-to-map-…
baogorek fc197c8
adding a test
baogorek 912b6e4
tests for qbid_amount
baogorek d1953f3
Add QBI qualification flags and update QBI formula
baogorek 81e7edc
Merge pull request #6058 from PolicyEngine/codex/add-new-qualified-bu…
baogorek 6e99bb5
Fix uprating for QBI income variables
baogorek 47fbb1d
Merge pull request #6059 from PolicyEngine/codex/fix-uprating-logic-f…
baogorek dfbe13b
Format files with black
baogorek 62dc758
Merge pull request #6065 from PolicyEngine/codex/run-black-linter-on-…
baogorek ddc36bc
Merge branch 'master' of github.com:PolicyEngine/policyengine-us into…
baogorek a297757
responding to reviewer requests
baogorek 4b0ddc0
adding references
baogorek e792429
reverting qbid logic files
baogorek 58c1fcd
Removing new files added as they are part of the new branch now
baogorek c38872f
Split income variables into separate files
baogorek fe2cce3
Merge pull request #6069 from PolicyEngine/codex/refactor-income.py-i…
baogorek 8725c53
linting
baogorek df06bed
cleaning up the emp_self_emp_ratio situation
baogorek 65ae818
linter
baogorek 23f3803
Update changelog for QBID preparation variables
baogorek 02e258a
Merge pull request #6075 from PolicyEngine/codex/update-changelog_ent…
baogorek aa58dd3
adding one more thing to the changelog
baogorek c2e157f
yet another changelog mod
baogorek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| - bump: minor | ||
| changes: | ||
| added: | ||
| - estate_income_would_be_qualified | ||
| - farm_operations_income_would_be_qualified | ||
| - farm_rent_income_would_be_qualified | ||
| - partnership_s_corp_income_would_be_qualified | ||
| - rental_income_would_be_qualified | ||
| - self_employment_income_would_be_qualified | ||
| changed: | ||
| - qualified_business_income | ||
|
|
||
| - bump: patch | ||
baogorek marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| changes: | ||
| fixed: | ||
| - corrected uprating for QBI dividend income variables | ||
| - documented uprating for farm_operations_income | ||
12 changes: 12 additions & 0 deletions
12
policyengine_us/parameters/gov/contrib/reconciliation/qbid/use_bdc_income.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| description: The reconciled QBID includes business development company income if this is true. | ||
baogorek marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| values: | ||
| 0000-01-01: false | ||
|
|
||
| metadata: | ||
| unit: bool | ||
| period: year | ||
| label: QBID includes a proportion of BDC income | ||
baogorek marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| reference: | ||
| - title: Providing for reconciliation pursuant to H.Con.Res. 14, the Concurrent Resolution on the Budget for Fiscal Year 2025 | ||
| href: "https://docs.house.gov/meetings/WM/WM00/20250513/118260/BILLS-119CommitteePrintih.pdf#page=7" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
policyengine_us/parameters/gov/irs/deductions/qbi/phase_out/length.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baogorek marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
...e_us/tests/policy/baseline/gov/irs/income/taxable_income/deductions/qbid/qbid_amount.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| - name: Meade and Shroff Entity 1 with no REIT/PTP income | ||
| period: 2022 | ||
| input: | ||
| qualified_business_income: 80_000 | ||
| w2_wages_from_qualified_business: 8_000 | ||
| unadjusted_basis_qualified_property: 50_000 | ||
| taxable_income_less_qbid: 400_100 | ||
| qualified_reit_and_ptp_income: 0 | ||
| business_is_sstb: False | ||
| filing_status: JOINT | ||
| output: | ||
| qbid_amount: 8_800 | ||
|
|
||
| - name: Meade and Shroff Entity 1 plus $1K in REIT/PTP income | ||
| period: 2022 | ||
| input: | ||
| qualified_business_income: 80_000 | ||
| w2_wages_from_qualified_business: 8_000 | ||
| unadjusted_basis_qualified_property: 50_000 | ||
| taxable_income_less_qbid: 400_100 | ||
| qualified_reit_and_ptp_income: 1000 | ||
| business_is_sstb: False | ||
| filing_status: JOINT | ||
| output: | ||
| qbid_amount: 9_000 | ||
|
|
||
| - name: Meade and Shroff Entity 1, no REIT/PTP, higher taxable income | ||
| period: 2022 | ||
| input: | ||
| qualified_business_income: 80_000 | ||
| w2_wages_from_qualified_business: 8_000 | ||
| unadjusted_basis_qualified_property: 50_000 | ||
| taxable_income_less_qbid: 460_100 | ||
| qualified_reit_and_ptp_income: 0 | ||
| business_is_sstb: False | ||
| filing_status: JOINT | ||
| output: | ||
| qbid_amount: 4_000 | ||
|
|
||
| - name: Meade and Shroff Entity 1, no REIT/PTP, lower taxable income | ||
| period: 2022 | ||
| input: | ||
| qualified_business_income: 80_000 | ||
| w2_wages_from_qualified_business: 8_000 | ||
| unadjusted_basis_qualified_property: 50_000 | ||
| taxable_income_less_qbid: 330_100 | ||
| qualified_reit_and_ptp_income: 0 | ||
| business_is_sstb: False | ||
| filing_status: JOINT | ||
| output: | ||
| qbid_amount: 16_000 | ||
|
|
||
| - name: Meade and Shroff Entity 5, no REIT/PTP | ||
| period: 2022 | ||
| input: | ||
| qualified_business_income: 110_000 | ||
| w2_wages_from_qualified_business: 60_000 | ||
| unadjusted_basis_qualified_property: 6_000 | ||
| taxable_income_less_qbid: 400_100 | ||
| qualified_reit_and_ptp_income: 0 | ||
| business_is_sstb: True | ||
| filing_status: JOINT | ||
| output: | ||
| qbid_amount: 8_800 |
26 changes: 26 additions & 0 deletions
26
...ne/gov/irs/income/taxable_income/deductions/qbid/qualified_business_income_deduction.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| - name: Taxable income over QBI in 2024 | ||
| period: 2024 | ||
| input: | ||
| qbid_amount: 10_000 | ||
| taxable_income_less_qbid: 30_000 | ||
| adjusted_net_capital_gain: 2_000 | ||
| output: | ||
| qualified_business_income_deduction: 5_600 | ||
|
|
||
| - name: Taxable income under QBI in 2024 | ||
| period: 2024 | ||
| input: | ||
| qbid_amount: 3_000 | ||
| taxable_income_less_qbid: 30_000 | ||
| adjusted_net_capital_gain: 2_000 | ||
| output: | ||
| qualified_business_income_deduction: 3_000 | ||
|
|
||
| - name: Taxable reduced to 0 | ||
| period: 2024 | ||
| input: | ||
| qbid_amount: 10_000 | ||
| taxable_income_less_qbid: 30_000 | ||
| adjusted_net_capital_gain: 32_000 | ||
| output: | ||
| qualified_business_income_deduction: 0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.