Skip to content

Add child poverty impact extension #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PavelMakarchuk wants to merge 5 commits into from
Closed

Add child poverty impact extension #100

PavelMakarchuk wants to merge 5 commits into from

Conversation

@PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk commented Feb 14, 2025

Fixes #99

@nikhilwoodruff
Copy link
Collaborator

nikhilwoodruff commented Feb 17, 2025

This is super helpful! Notes from our discussion:

  • Overall the syntax works well.
  • To enable more complex analyses to work well, we should drop the simulation parameters from the Simulation initialisation call to the actual function we ask users to define, and instead surface the simulation initialisation functions in Simulation to functions.
  • We should provide guidance on avoiding overloading the memory limits in the documentation.

@nikhilwoodruff nikhilwoodruff mentioned this pull request Feb 17, 2025
Closed
@nikhilwoodruff nikhilwoodruff force-pushed the main branch 2 times, most recently from 4af80eb to 59f7b2b Compare February 21, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhilwoodruff nikhilwoodruff Awaiting requested review from nikhilwoodruff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add child poverty impact extension

3 participants

@PavelMakarchuk @nikhilwoodruff