Skip to content

Conversation

@anth-volk
Copy link
Contributor

@anth-volk anth-volk commented May 6, 2025

Fixes #115

This PR:

  1. Converts "Infinity" to np.inf and "-Infinity" to -np.inf
  2. Adds testing
  3. Creates subschemas for the ParametricReform schema to explicitly support and validate three reform input types:
{
  "param": 15_000
}
{
  "param": {
    "2024": 15_000
  }
}
{
  "param": {
    "2024-01-01.2025-12-31": 15_000
  }
}

@anth-volk anth-volk requested a review from nikhilwoodruff May 6, 2025 20:21
@anth-volk anth-volk marked this pull request as draft May 7, 2025 20:57
@anth-volk anth-volk force-pushed the fix/handle-infinity branch from a0418fc to 7a3eb9b Compare May 7, 2025 22:03
@anth-volk anth-volk marked this pull request as ready for review May 7, 2025 22:06
Copy link
Collaborator

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and yes conforms to what I'd expect the schema to be.

@anth-volk
Copy link
Contributor Author

Will merge after tests pass, given addressing of all issues and pre-emptive approval from Nikhil

@nikhilwoodruff nikhilwoodruff merged commit 7971c0c into main May 15, 2025
3 checks passed
@nikhilwoodruff nikhilwoodruff deleted the fix/handle-infinity branch May 15, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create reform serializer and deserializer

3 participants