-
Notifications
You must be signed in to change notification settings - Fork 8
Add country package version to economy comparisons #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikesmit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One opinionated comment, otherwise nitts or questions.
|
Update: tests fail due to a typo in the schema definition |
|
Modifying based on review. Switching to draft until complete. |
mikesmit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One opinionated comment, otherwise nitts or questions.
Fixes #125.
What Changed
EconomyComparisonschema to includecountry_package_versionkeycalculate_economy_comparison()to provide the country package version key as part of its returnedEconomyComparisondictWhy This Change