Skip to content

Conversation

@nikhilwoodruff
Copy link
Collaborator

Fixes #130

@nikhilwoodruff nikhilwoodruff self-assigned this May 15, 2025
@nikhilwoodruff nikhilwoodruff requested a review from anth-volk May 16, 2025 08:27
Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a real pleasure going through this code @nikhilwoodruff. Left some minor change recommendations, but think we're close to the finish line!

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk May 19, 2025 10:05
Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll open a separate issue in API to add a cliff impact test for integration testing purposes.

@nikhilwoodruff nikhilwoodruff merged commit 01b4fe7 into main May 20, 2025
4 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue130 branch May 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable cliff impacts

3 participants