Enable cliff impacts #131
Merged
Enable cliff impacts #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #130
anth-volk
reviewed
May 15, 2025
anth-volk
reviewed
May 15, 2025
anth-volk
reviewed
May 15, 2025
anth-volk
reviewed
May 15, 2025
policyengine/outputs/macro/comparison/calculate_economy_comparison.py
Outdated
Show resolved
Hide resolved
anth-volk
reviewed
May 15, 2025
policyengine/outputs/macro/comparison/calculate_economy_comparison.py
Outdated
Show resolved
Hide resolved
anth-volk
reviewed
May 15, 2025
anth-volk
reviewed
May 15, 2025
anth-volk
reviewed
May 16, 2025
Contributor
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
It was a real pleasure going through this code @nikhilwoodruff. Left some minor change recommendations, but think we're close to the finish line!
Fixes #130
anth-volk
approved these changes
May 19, 2025
Contributor
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
LGTM! I'll open a separate issue in API to add a cliff impact test for integration testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130