Add CachingGoogleStorageClient #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anth-volk
reviewed
May 15, 2025
| from policyengine.utils.data import CachingGoogleStorageClient | ||
|
|
||
|
|
||
| class MockedStorageSupport: |
Contributor
There was a problem hiding this comment.
suggestion, non-blocking: Separate fixtures out into test/fixtures/data/filepath
Collaborator
Author
There was a problem hiding this comment.
Chatted on slack and decided to put it in a conftest.py file. which I'm doing in a new revision now.
I'm kind of on the fence here. If it's small and only used by one test I tend to want to have it next to the thing being tested, but I also buy it's better to remove clutter and just have the test code in the test file.
mikesmit
force-pushed
the
350_add_caching_google_storage_client
branch
2 times, most recently
from
4f3f1b0 to
4e609bf
Compare
Related to PolicyEngine/issues#350 This commit adds, but does not yet use, CachingGoogleStorageClient which is a class used to monitor a remote file in google storage for changes caching the result locally to disk.
mikesmit
force-pushed
the
350_add_caching_google_storage_client
branch
from
4e609bf to
52585de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PolicyEngine/issues#350
This commit adds, but does not yet use, CachingGoogleStorageClient which is a class used to monitor a remote file in google storage for changes caching the result locally to disk.