Skip to content

Conversation

@nikhilwoodruff
Copy link
Collaborator

Fixes #147

@nikhilwoodruff nikhilwoodruff self-assigned this May 23, 2025
Copy link
Collaborator Author

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes:

  1. Drop support for Hugging Face in policyengine.py as discussed.
  2. Download the actual dataset version (after data package changes add this) using a new format:

data="gcs://bucket/[email protected]"

  1. When no version is specified, log the version of the dataset we used and warn the user that we're using this version.
  2. Added pip install prompt when model versions don't match.

@nikhilwoodruff
Copy link
Collaborator Author

@anth-volk added the changes from our in-person review just now.

nikhilwoodruff

This comment was marked as duplicate.

@nikhilwoodruff
Copy link
Collaborator Author

@anth-volk I also changed the version syntax because I think it's cleaner to have a standardised model_version and data_version property pair.

Old (this PR): data=gcs://bucket/filename.h5@version + model_version="1.0.0"
New (this PR): data=gcs://bucket/filename.h5 + data_version=version + model_version="1.0.0"

Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the work on this PR @nikhilwoodruff. Had a few thoughts and a couple questions in the comments. Additionally, wanted to ask if you could add relevant tests for new methods and one test to ensure that the function that adds the most recent version when its version arg is None does so properly.

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk May 26, 2025 20:35
@nikhilwoodruff
Copy link
Collaborator Author

@anth-volk addressed your comments, and added tests for the new functionality.

Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor blocking issue: Optional-typed fields still need a default value to avoid validation errors when the field isn't passed. Otherwise, looking forward to getting this over the line today!

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk May 26, 2025 21:16
Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited to get this code in @nikhilwoodruff! It's been a pleasure reviewing.

@nikhilwoodruff nikhilwoodruff merged commit ebd736f into main May 26, 2025
4 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue147 branch May 26, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add versions argument to Simulation

3 participants