feat: Add support for breakdown_labels and nested breakdowns #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
- Add _find_breakdown_parent() to walk up tree and find breakdown ancestor - Update _generate_breakdown_label() to handle nested breakdowns - Add _collect_dimension_values() to collect all dimension values along path - Add _format_dimension_value() to format values with semantic labels - Support breakdown_labels metadata for range() dimensions - Add comprehensive tests for nested breakdowns and breakdown_labels 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
anth-volk
force-pushed
the
fix/apply-labels-to-nested-breakdowns
branch
from
78688be to
43c116a
Compare
The breakdown metadata can contain lists, so we need to check isinstance(var_name, str) before calling startswith(). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #210
_find_breakdown_parent()to walk up tree and find breakdown ancestor_collect_dimension_values()to collect dimension values along path_format_dimension_value()to format values with semantic labelsbreakdown_labelsmetadata forrange()dimensions_generate_breakdown_label_simplefunctionThis enables human-readable labels like "SNAP max allotment (Contiguous US, Household size 1)" instead of "(CONTIGUOUS_US, 1)".
Test plan
🤖 Generated with Claude Code