Fix parameter path syntax for non-scale parameters#2
Draft
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Virginia tax and benefit reform calculator with household and statewide impact analysis for CTC, EITC, and income tax rate reforms at federal and state levels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix federal bracket rates to use 1-indexed keys (range(1,8)) matching YAML - Add .amount sub-key to EITC max bracket scale paths - Add .rate sub-key to VA income tax rate bracket scale paths - Add postcss.config.mjs with @tailwindcss/postcss plugin (required for Tailwind v4) - Add @tailwindcss/postcss and postcss as devDependencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PolicyEngine parameter nodes (income bracket rates, CTC phase-out thresholds, VA standard deduction) use dot notation (rates.1, threshold.SINGLE), not bracket notation (rates[1], threshold[SINGLE]). Bracket syntax is only for ParameterScale objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Summary
gov.irs.income.bracket.rates[1]→rates.1ctc.phase_out.threshold[SINGLE]→threshold.SINGLEva.tax.income.deductions.standard[SINGLE]→standard.SINGLEBracket syntax is only valid for
ParameterScaleobjects (YAML withbrackets:key). Regular parameter nodes use dot access.Test plan
ValueError🤖 Generated with Claude Code