Name developer field with data index#5
Name developer field with data index#5dpwiese wants to merge 2 commits intoupdate-master-from-parse-fitfrom
Conversation
|
Hey hi! This is a great change but could you show some examples? I am curious |
|
@jimmykane - I'm not sure how much I can help beyond what is in the PR description above, but these changes were a quick and dirty workaround to using easy-fit to parse FIT files which may contain multiple developer data fields which all have the same With the above changes each These changes have served their purpose for now, although it's not an elegant solution to this problem and I've yet to have time to revisit it since. Hope this helps! |
|
@dpwiese got I think I understand what you mean. I ll give it a try / check and perhaps merge it to fit-file-parser (updated npm for easyfit) and also to the typescript project we work with Piere |
|
tbh, I'd not feel great about merging as-is until this particular problem can be given more attention. I'd expect there to be a more elegant way to solve this problem. Perhaps return an array of identically named developer data fields? |
|
Ok thanks! |
This (WIP) PR appends the name of developer data fields with their corresponding
developer_data_index. The reason is that more than one developer data field may be used, each that has fields with the same name. In the current implementation, only one of these fields will be populated in each record.This PR (inelegantly) differentiates between these multiple developer data fields by appending the
developer_data_indexto the end of the name.