Generate playlists from multiple songs#53
Generate playlists from multiple songs#53SimonTeixidor wants to merge 1 commit intoPolochon-street:masterfrom
Conversation
|
Hi, Time to tackle this one! First, thanks a lot for submitting 😁 Second, I think (at least that's my use case and the use case of some other people I know) that it would be nice to keep the euclidean / playlist from one song as the default. The use case is to listen to all a library's song at random and then generate a playlist from the song that's currently playing - and I think it's nicer for people if their workflow doesn't becomes disrupted upon update, trying to make changes as little breaking as possible :) I'll give it a more thorough review in the upcoming days, but that's my two cents so far 😄 |
0c1fc96 to
080bc25
Compare
|
hi @SimonTeixidor! I just released I also made some extensive changes on the decoder's backend, so I just merged this b63e087 to make sure everything was working as it should, but it also incorporates the changes you made to the various distance functions :) I think it would be nice to add a flag to do a Cheers! |
|
Hi! Sorry for letting this PR sit for so long, I've been busy with other things lately. It looks like you have pretty much incorporated these changes in #59, right? If so, I think we can just close this PR. |
|
Hi! They are indeed incorporated in #59, but would you mind giving it a review before I merge it? You know much better how it works than I do, and I'm not sure about e.g. the parameters for the forest here https://github.com/Polochon-street/blissify-rs/pull/59/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR826-R831 :) |
7e068cd to
d4be94b
Compare
This PR uses my branch of bliss-rs to generate playlists based on multiple songs, instead of just the currently playing song. To me it makes the most sense to generate a playlist based on the entirety of the current playlist, so I made this the default behaviour and added a flag (
--from-current-song) for the old behaviour.