Skip to content

Commit 35913a9

Browse files
committed
Use #assertEmpty: when possible
1 parent 8a1f547 commit 35913a9

File tree

1 file changed

+17
-29
lines changed

1 file changed

+17
-29
lines changed

src/DataFrame-Tests/DataFrameTest.class.st

Lines changed: 17 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -4904,26 +4904,21 @@ DataFrameTest >> testWithColumnsRowNamesColumnNames [
49044904

49054905
{ #category : #tests }
49064906
DataFrameTest >> testWithColumnsRowNamesColumnNames_emptyColumns [
4907+
49074908
| dataframe |
4908-
dataframe := DataFrame
4909-
withColumns: #()
4910-
rowNames: #('1' '2')
4911-
columnNames: #().
4912-
self assert: dataframe rowNames asArray equals: #('1' '2').
4913-
self assert: (dataframe row: '1') isEmpty.
4914-
self assert: (dataframe row: '2') isEmpty
4909+
dataframe := DataFrame withColumns: #( ) rowNames: #( '1' '2' ) columnNames: #( ).
4910+
self assert: dataframe rowNames asArray equals: #( '1' '2' ).
4911+
self assertEmpty: (dataframe row: '1').
4912+
self assertEmpty: (dataframe row: '2')
49154913
]
49164914

49174915
{ #category : #tests }
49184916
DataFrameTest >> testWithColumnsRowNames_emptyColumns [
4917+
49194918
| dataframe |
4920-
dataframe := DataFrame
4921-
withColumns: #()
4922-
rowNames: #('one' 'two' 'three').
4923-
self
4924-
assert: dataframe rowNames asArray
4925-
equals: #('one' 'two' 'three').
4926-
self assert: (dataframe row: 'one') isEmpty
4919+
dataframe := DataFrame withColumns: #( ) rowNames: #( 'one' 'two' 'three' ).
4920+
self assert: dataframe rowNames asArray equals: #( 'one' 'two' 'three' ).
4921+
self assertEmpty: (dataframe row: 'one')
49274922
]
49284923

49294924
{ #category : #tests }
@@ -5042,14 +5037,11 @@ DataFrameTest >> testWithRowsColumnNames [
50425037

50435038
{ #category : #tests }
50445039
DataFrameTest >> testWithRowsColumnNames_emptyRows [
5040+
50455041
| dataframe |
5046-
dataframe := DataFrame
5047-
withRows: #()
5048-
columnNames: #('one' 'two' 'three').
5049-
self
5050-
assert: dataframe columnNames asArray
5051-
equals: #('one' 'two' 'three').
5052-
self assert: (dataframe column: 'one') isEmpty
5042+
dataframe := DataFrame withRows: #( ) columnNames: #( 'one' 'two' 'three' ).
5043+
self assert: dataframe columnNames asArray equals: #( 'one' 'two' 'three' ).
5044+
self assertEmpty: (dataframe column: 'one')
50535045
]
50545046

50555047
{ #category : #tests }
@@ -5072,13 +5064,9 @@ DataFrameTest >> testWithRowsRowNamesColumnNames [
50725064

50735065
{ #category : #tests }
50745066
DataFrameTest >> testWithRowsRowNamesColumnNames_emptyRows [
5067+
50755068
| dataframe |
5076-
dataframe := DataFrame
5077-
withRows: #()
5078-
rowNames: #()
5079-
columnNames: #('one' 'two' 'three').
5080-
self
5081-
assert: dataframe columnNames asArray
5082-
equals: #('one' 'two' 'three').
5083-
self assert: (dataframe column: 'one') isEmpty
5069+
dataframe := DataFrame withRows: #( ) rowNames: #( ) columnNames: #( 'one' 'two' 'three' ).
5070+
self assert: dataframe columnNames asArray equals: #( 'one' 'two' 'three' ).
5071+
self assertEmpty: (dataframe column: 'one')
50845072
]

0 commit comments

Comments
 (0)