Issue/352 prevent unnecessary reconnects

[alexzobi]

Prevent Unnecessary Reconnects

Description

This PR stems from the issue I reported around input connections. See the issue for steps to recreate the bug. To fix this, I added a port name to the input manager and check that the port names match before deciding whether or not i should try to reconnect. as well, I added logic to explicitly drop previous connections before attempting to reconnect. Doing these things has led to more stable input manager connections.

Key Changes

MIDI input connection lifecycle

• prevent unnecessary reconnects by checking if current connection matches desired connection
• track currently connected input port

Improved MIDI port Identity

• rely on stable ids via port name instead of connection state
• add port index mapping to handle multiple ports with identical names

Testing

1. Start the app
2. Select a midi file to play
3. hit the "play" button // inputs should work as expected
4. hit the "back" button to return to the main menu
5. hit the "play" button to again return to the playing scene.
6. if keyboard inputs still work as expected, you win.

[PolyMeilex]

This will probably depend on a platform used, but what will happen if I connect to a keyboard, then physically unplug it, and plug it back again, will it still have the same name and therefore stay unconnected because of the initial unplug?

[alexzobi]

checked and you are correct, based on previous code, no connection was reformed. I have updated the code to ensure that input connections reform on scene change. I was considering changing the location of the checks outside of the menu_scene/state.rs which would prevent users from having to navigate back to the main menu and then back to the playing menu upon disconnect/reconnect, but didn't want to add polling logic to the main event loop without your consideration, so as for now, it operates as before, from the menu_scene only.

[PolyMeilex]

Sadly there are way too many LLM hallucinations in this diff, could you try my fix for this and let me know if it works for you: #357 ?

Seems to work fine on my Win11 test setup.