Java selection UI overhaul #250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everything works without rules
needs more testing still inconsistent sometimes
- Introduced `check_java` and `locate_java` commands for Java version management. - Updated `GameSettings` and `JvmSettings` components to include memory settings. - Enhanced UI for Java settings with auto-detection and search functionality for Java executables. - Removed unused memory settings from the UI to streamline the user experience. man i like this ai commit message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Java selection UI and enhances JVM-related settings, including JVM arguments, environment variables, and memory allocation.
Related Issue(s)
LAUNCHER-30
Showcase
2025-03-28.15-09-54.mp4