Skip to content

fix(store): move SqliteStore export from universal to node entry#10

Merged
niconiconi merged 1 commit intomainfrom
fix/export_node_only
Mar 7, 2026
Merged

fix(store): move SqliteStore export from universal to node entry#10
niconiconi merged 1 commit intomainfrom
fix/export_node_only

Conversation

@hczphn
Copy link
Copy Markdown
Collaborator

@hczphn hczphn commented Mar 6, 2026

Summary

  • Move SqliteStore export from src/index.ts (universal) to src/index.node.ts (node-only)
  • SqliteStore depends on node:sqlite and better-sqlite3, which are Node-only modules
  • The universal entry's export * pulled SqliteStore into dist/browser.js, causing Vite 7+ to fail on import("sqlite") static analysis

Before

dist/browser.js contained import("sqlite") → Vite 7 error:

Failed to resolve import "sqlite" from "dist/browser.js"

After

  • dist/browser.js: 0 sqlite references
  • dist/node.js: SqliteStore fully available
  • dist/index.js: no longer contains Node-only module

Test plan

  • pnpm run type-check passes
  • pnpm run test — 37/37 files, 115/115 tests pass
  • dist/browser.js contains zero sqlite references
  • dist/node.js still exports SqliteStore

🤖 Generated with Claude Code

SqliteStore depends on node:sqlite and better-sqlite3 which are
Node-only modules. Exporting from the universal entry caused them
to be bundled into dist/browser.js, breaking Vite 7+ which
statically analyzes all dynamic import() calls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the module exports to properly isolate Node.js-specific components, specifically the SqliteStore, from the universal build. By moving the SqliteStore export to the Node.js entry point, the change prevents build failures in browser environments caused by Node-only dependencies, thereby improving the library's compatibility and ensuring a cleaner separation of concerns between universal and platform-specific code.

Highlights

  • Module Export Relocation: The SqliteStore and its associated types (SqliteStoreOptions) have been moved from the universal src/index.ts entry point to the Node.js-specific src/index.node.ts entry point.
  • Dependency Scoping: This change correctly scopes SqliteStore, which relies on Node-only modules like node:sqlite and better-sqlite3, ensuring it is only exposed in Node.js environments.
  • Build Compatibility Fix: The relocation resolves an issue where Vite 7+ would fail during static analysis in browser builds (dist/browser.js) due to unexpected import("sqlite") references, by ensuring no SQLite references exist in the browser bundle.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/index.node.ts
    • Exported SqliteStore and SqliteStoreOptions.
    • Updated the file's descriptive comment to reflect the inclusion of SQLite storage.
  • src/index.ts
    • Removed SqliteStore and SqliteStoreOptions exports.
Activity
  • Type checks passed (pnpm run type-check).
  • All tests passed (pnpm run test — 37/37 files, 115/115 tests).
  • Verified that dist/browser.js contains zero sqlite references.
  • Confirmed that dist/node.js still exports SqliteStore.
  • The PR summary was generated with Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves the SqliteStore export from the universal entry point (src/index.ts) to the Node.js-specific entry point (src/index.node.ts). This change is necessary because SqliteStore has Node.js-specific dependencies, and this refactoring resolves build failures in browser environments like Vite. The changes are accurate and effectively address the described issue.

@niconiconi niconiconi merged commit ab6ee82 into main Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants