Skip to content

Small Refactor #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EiffL merged 7 commits into from
Jun 17, 2025
Merged

Small Refactor #31

EiffL merged 7 commits into from
Jun 17, 2025

Conversation

@LTMeyer
Copy link
Collaborator

@LTMeyer LTMeyer commented May 30, 2025

This PR update some features related to modalities:

  • It allows to check the compatibility between codec and modality, when loading a codec.
  • It adds subclass modalities to the config to simplify the logic of the codec manager
  • It simplifies modality class retrieval in scalar codecs.

@LTMeyer LTMeyer requested a review from EiffL May 30, 2025 13:21
@LTMeyer LTMeyer mentioned this pull request May 30, 2025
Merged
4 tasks
@EiffL EiffL changed the base branch from hf-upload to main June 17, 2025 16:10
EiffL
EiffL approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffL EiffL merged commit cec2804 into main Jun 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EiffL EiffL EiffL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LTMeyer @EiffL