-
Notifications
You must be signed in to change notification settings - Fork 8
Add stellar tutorial and refactor AION forward generation for improved ease of use #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EiffL
approved these changes
Jun 27, 2025
Contributor
EiffL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
README.mdfile and significant changes to theaioncodebase, focusing on modality definitions and the model's forward pass logic. The most notable changes include addingnum_tokensattributes to various modality classes, refactoring theforwardmethod in the model to dynamically compute encoder and decoder tokens, and improving the documentation.Documentation Updates:
README.md: Added a centered AION logo image for better visual presentation and renamed the "Key Use Cases" section to "Example Use Cases" for clarity. [1] [2]Modality Enhancements:
aion/modalities.py: Introduced anum_tokensattribute to all modality classes (e.g.,HSCImage,LegacySurveyImage,DESISpectrum,GaiaFluxG, etc.) to define the number of tokens each modality contributes. This enables dynamic token handling in the model. [1] [2] [3] [4] [5]Model Forward Pass Refactor:
aion/model.py: Refactored theforwardmethod to dynamically computenum_encoder_tokensandnum_decoder_tokensbased on input and target modalities. Added a helper_forwardmethod for modularity, and replacedtarget_maskwithtarget_modalityas an input parameter for better usability.These changes collectively enhance the flexibility and maintainability of the codebase, particularly in handling diverse astronomical modalities and adapting to varying input/output configurations.