Conversation
francois-rozet
left a comment
There was a problem hiding this comment.
The approach seems sound to me, if the training scripts still run. I just left a minor comment.
Co-authored-by: François Rozet <francois.rozet@outlook.com>
I've just tried the following and it worked as expected. |
|
To be sure, does it work for 3D data as well? |
It should. If you have a command you would like me to test let me know. |
Could you try the same command for training on the |
With the tests I've noticed by the way that some models seem to accept |
I've just checked the following command runs as expected |
…-computation-of-statistics 33 issue with dataloader and computation of statistics
…-computation-of-statistics 33 issue with dataloader and computation of statistics
Context
We want to upload the checkpoints of the model trained for the benchmark to HF (see #33).
To ease the loading of the checkpoints
from_pretrained(<hf_url>)and not having to pass any redundant parameters this requires all the parameters of the model class to be of standard type. This is not the case as we use thedataset.metadatafor instantiation. This PR fixes it by setting explicitly then_spatial_dimsandspatial_resolutionarguments that were originally extracted from the metadata.Content
BaseModelclass to support HF upload;dset_metadata-> actualn_spatail_dimsandspatial_resolutionarguments: