added max rollout steps to dataset docstring #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccabe210
approved these changes
May 20, 2025
LTMeyer
requested changes
May 21, 2025
Collaborator
LTMeyer
left a comment
LTMeyer
left a comment
There was a problem hiding this comment.
Thank you @FloWsnr for your contribution! Any improvement on the documentation is much welcomed.
I believe it can be even clearer that the full trajectory gets returned in case max_rollout_steps is larger than its actual length.
Co-authored-by: Lucas Meyer <LTMeyer@users.noreply.github.com>
Contributor
Author
|
Good idea, @LTMeyer, I commited your change! |
LTMeyer
approved these changes
May 21, 2025
kazewong
pushed a commit
that referenced
this pull request
Nov 5, 2025
* added max rollout steps to dataset docstring * Update the_well/data/datasets.py Co-authored-by: Lucas Meyer <LTMeyer@users.noreply.github.com> --------- Co-authored-by: Lucas Meyer <LTMeyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I realized that the parameter max_rollout_steps is not present in the dataset docstring nor the docs on the website. This lead to some confusion since we wanted to get a full 500 step trajectory.
Best,
Florian