fix: stop overwriting best.pt every validation
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @till-m thank you for your PR. It looks good to me, I'll let @mikemccabe210 double check it and approve it if it's good for him. |
Contributor
Author
|
Thanks for having a look. Just to let you know, initially, I was looking for a problem with the checkpoints due to some oddity in the validation loss I saw during training. Now I'm sure there is (potentially in addition to this) another thing going on, so please check the PR carefully. |
Contributor
|
Thanks for the contribution @till-m! Seems like a good change. |
mikemccabe210
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.best_val_lossis never set, soself.best_val_loss is Noneis alwaysTrue, which causes thebest.ptcheckpoint to be overwritten every validation step during training.