Skip to content

fix: denominator calculation for short validation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikemccabe210 merged 2 commits into from
Oct 21, 2025
Merged

fix: denominator calculation for short validation #61

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b7691
Fix denominator calculation for validation length
t-muser Oct 20, 2025
be8fc1f
fix: linting
t-muser Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion the_well/benchmark/trainer/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def validation_loop(
loss_dict = {}
time_logs = {}
count = 0
denom = len(dataloader) if full else self.short_validation_length
denom = len(dataloader) if full else min(self.short_validation_length, len(dataloader))
with torch.autocast(
self.device.type, enabled=self.enable_amp, dtype=self.amp_type
):
Expand Down
Loading