-
-
Notifications
You must be signed in to change notification settings - Fork 403
Update project to .NET 10 #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A lot of the testing framework in EFCore has been changed. Eg: ComplexTypeBulkUpdatesRelationalTestBase has been removed: dotnet/efcore@9a34953#diff-869d25410b8e3b121608a4d3d2cd2a3950bb7229ee23e39f4ba010f142dfba97 Can this pr be fixed? |
|
I noticed that too. A lot of the testing framework in EFCore has been changed. I tried to fix these unit tests (UTs), but the changes are incredibly huge. I'm currently using Gemini to help, comparing Microsoft's before-and-after code to try and fix it. But Gemini is almost no help (it's still too dumb for such complex context). I've struggled for several hours, and for many of the fixes, I'm not even sure if they are the correct way to fix them. That's why I've been hesitant to push. Also, I am not the author of this project. Our company (Aiursoft) is in a hurry to migrate all our projects to .NET 10, but I've obviously run into the exact same predicament as you with this library. I think it would be best if we could contact the actual author of Pomelo to get a clear, official timeline. Additionally, on the branch for this pull request, although the tests fail to compile, the WARNING: NOT FOR PRODUCTION!!!dotnet add package Aiursoft.EntityFrameworkCore.MySql --version 10.0.1-servicing.1 |
|
Guys, we don't accept PRs for upgrades to another major EF Core version (especially not from anyone without an established contribution history to the project). The risk is too high (we tried in the past). I am actively working on the upgrade and I am way ahead of you. As every year, that includes all the tests for all actively maintained versions of MySQL and MariaDB. You don't have to burn time here. If you want to contribute to the project, feel free to tackle one of the open issues (there are quite a few and we really appreciate contributions in that area). |
Branch name please? |
|
Hi @lauxjpn . We are still working on migrating from .NET 9 to .NET 10 recently. This package is the only one blocking. Can you push the .NET 10 branch so we can build it on our side and unblock this? |
|
@Anduin2017 You can find the (work-in-progress) upgrade to EF Core 10 in PR #2019. Also be aware that Pomelo 9 & EF Core 9 are compatible with .NET 10. Unless you are dependent on new EF Core 10 features, you should just be able to use Pomelo 9 & EF Core 9 for now, when upgrading you project(s) to .NET 10. |
Working in progress..
Fix #2016 #2007
Currently seems test projects building are still failing..