Skip to content

💥 Remove Drop trait from write::Xz[En/De]coder #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

💥 Remove Drop trait from write::Xz[En/De]coder #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,6 @@ impl<W: Read + Write> Read for XzEncoder<W> {
#[cfg(feature = "tokio")]
impl<W: AsyncRead + AsyncWrite> AsyncRead for XzEncoder<W> {}

impl<W: Write> Drop for XzEncoder<W> {
#[inline]
fn drop(&mut self) {
if self.obj.is_some() {
let _ = self.try_finish();
}
}
}

impl<W: Write> XzDecoder<W> {
/// Creates a new decoding stream which will decode into `obj` one xz stream
/// from the input written to it.
Expand Down Expand Up @@ -363,15 +354,6 @@ impl<W: Read + Write> Read for XzDecoder<W> {
#[cfg(feature = "tokio")]
impl<W: AsyncRead + AsyncWrite> AsyncRead for XzDecoder<W> {}

impl<W: Write> Drop for XzDecoder<W> {
#[inline]
fn drop(&mut self) {
if self.obj.is_some() {
let _ = self.try_finish();
}
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down