Skip to content

requestId is assigned even in non-payments activity with the nostr event id #280

Description

@miche1e

Activities have a field called requestId which is specific to the payments protocol and often fetched from request.content.requestId.
In any other case (such as auth requests) this field is valued from the nostr eventId fetched from event.eventId.
Since the nostr event id has no purpose (beside app-side events deduplication which is already fixed by the new tasks architecture) this field has no utility.
We can:

  1. add a requestId for others requests ( -> time consuming, useless feature)
  2. make the requestId optional and only be valued by payments like invoice field ( -> quick but without measurable improvements)
  3. leave it as it is ( -> incoherent and confusing)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions