-
Notifications
You must be signed in to change notification settings - Fork 746
bedrock provider cleanup #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
bedrock provider cleanup #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review completed. Found several areas for improvement including missing error handling, potential security issues, and documentation gaps.
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
bc360ce
to
7a18e60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bedrock provider cleanup with proxy support and AWS endpoint domain improvements. Found critical null safety issues and missing error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamic import implementation looks correct but has potential type safety and performance issues
6680bde
to
4f5380c
Compare
add wrapper for environment variables with support for fetching from file path bedrock cleanup add conditional import
4f5380c
to
7f5640a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High complexity PR with bedrock provider cleanup and AWS endpoint domain support. Key changes include renaming azureExtraParams to azureExtraParameters, adding AWS endpoint domain support, and refactoring bedrock API configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bedrock provider cleanup with improved AWS endpoint handling and parameter standardization
Minor cleanup in requestBody type definition |
Changes included in this PR:
Changes not included:
Support for IRSA and IMDS based auth