Skip to content

Conversation

@avaya09
Copy link
Contributor

@avaya09 avaya09 commented Dec 28, 2025

Added templates to deploy -

  • MinIO
  • Milvus backed by MinIO

@avaya09 avaya09 requested a review from Copilot December 28, 2025 10:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Helm chart templates to deploy MinIO and Milvus (a vector database) within the Kubernetes cluster for the Portkey Gateway, enabling in-cluster object storage and semantic caching capabilities.

Key Changes:

  • Added Kubernetes manifests for deploying MinIO (object storage) and Milvus (vector database with etcd dependency)
  • Updated configuration documentation to include setup instructions for MinIO, Milvus, and semantic caching
  • Modified helper template to standardize app.kubernetes.io/managed-by label to "Helm"

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
charts/portkey-gateway/values.yaml Added configuration sections for MinIO and Milvus with container images, persistence, service, and statefulset settings
charts/portkey-gateway/templates/minio/statefulset.yaml New MinIO StatefulSet template with health probes, secrets, and persistent volume configuration
charts/portkey-gateway/templates/minio/service.yaml New MinIO Service exposing API and console ports
charts/portkey-gateway/templates/minio/secret.yaml New Secret template for MinIO credentials
charts/portkey-gateway/templates/milvus/milvus-statefulset.yaml New Milvus StatefulSet with MinIO and etcd integration
charts/portkey-gateway/templates/milvus/milvus-service.yaml New Milvus Service exposing gRPC and HTTP ports
charts/portkey-gateway/templates/milvus/milvus-config.yaml New ConfigMap for Milvus authorization settings
charts/portkey-gateway/templates/milvus/etcd-statefulset.yaml New etcd StatefulSet for Milvus metadata storage
charts/portkey-gateway/templates/milvus/etcd-service.yaml New etcd Service for Milvus
charts/portkey-gateway/templates/_helpers.tpl Added label helper templates for MinIO and Milvus components; standardized managed-by label
charts/portkey-gateway/docs/SemanticCache.md New documentation for semantic cache configuration with Milvus
charts/portkey-gateway/docs/Configuration.md Added configuration documentation for MinIO and Milvus parameters
charts/portkey-gateway/README.md Added MinIO setup instructions and semantic caching overview

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avaya09 avaya09 requested a review from Copilot December 28, 2025 10:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avaya09 avaya09 requested a review from sk-portkey December 29, 2025 06:16
@avaya09 avaya09 requested a review from Copilot December 29, 2025 14:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants