chore: refactor chat and text completion methods to custom remove str… #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaming response handling
dosubot
bot
added
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR refactors streaming response handling for chat and text completion methods by delegating the streaming logic to the OpenAI client's native implementation instead of custom string parsing.
Key Changes:
- Removed custom streaming response parsing logic that manually handled SSE (Server-Sent Events) data formatting
- Delegated streaming to OpenAI client's native
completions.create()andchat.completions.create()methods - Fixed missing
awaitkeywords in async stream method calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| portkey_ai/api_resources/apis/complete.py | Removed custom streaming response handling for text completions and fixed async/await for stream_create call |
| portkey_ai/api_resources/apis/chat_complete.py | Removed custom streaming response handling for chat completions and fixed async/await for stream_create call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b4s36t4
approved these changes
Nov 13, 2025
VisargD
deleted the
fix/remove-custom-chat-completions-stream-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eaming response handling
Title:
Description:
Motivation:
To avoid maintain dual stream handling logic
Related Issues:
#