Skip to content

feat: Improve OAuth handling #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charlesvien merged 2 commits into from
Jan 7, 2026
Merged

feat: Improve OAuth handling #402

charlesvien merged 2 commits into from
Jan 7, 2026

Conversation

@charlesvien
Copy link
Contributor

@charlesvien charlesvien commented Jan 7, 2026 •
edited
Loading

  • Added error codes to oauth service
  • Retry logic with exponential backoff
  • Singleton promise for token init and refresh
  • Preserve session on network errors

@charlesvien charlesvien requested a review from a team as a code owner January 7, 2026 01:27
@charlesvien charlesvien changed the base branch from main to graphite-base/402 January 7, 2026 01:41
@charlesvien charlesvien force-pushed the fix/oauth-refresh-handling branch from 7327980 to 4fd8f3f Compare January 7, 2026 01:41
@charlesvien charlesvien changed the base branch from graphite-base/402 to array/twilight-plum-stork January 7, 2026 01:41
@charlesvien Graphite App
Copy link
Contributor Author

charlesvien commented Jan 7, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 7, 2026
Merged
Merged
Merged
Merged
Merged
joshsny
joshsny approved these changes Jan 7, 2026
View reviewed changes
@charlesvien charlesvien force-pushed the array/twilight-plum-stork branch from c071e02 to 7c41e50 Compare January 7, 2026 16:29
@charlesvien charlesvien force-pushed the fix/oauth-refresh-handling branch from 4fd8f3f to 4f19e56 Compare January 7, 2026 16:29
@charlesvien charlesvien changed the base branch from array/twilight-plum-stork to graphite-base/402 January 7, 2026 21:11
@charlesvien charlesvien force-pushed the fix/oauth-refresh-handling branch from 4f19e56 to ff08351 Compare January 7, 2026 21:15
@graphite-app graphite-app bot changed the base branch from graphite-base/402 to main January 7, 2026 21:16
@charlesvien charlesvien force-pushed the fix/oauth-refresh-handling branch from ff08351 to af090c7 Compare January 7, 2026 21:16
@charlesvien Graphite App
Copy link
Contributor Author

charlesvien commented Jan 7, 2026 •
edited
Loading

Merge activity

  • Jan 7, 9:21 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 7, 9:21 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien merged commit 3342f05 into main Jan 7, 2026
11 checks passed
@charlesvien charlesvien deleted the fix/oauth-refresh-handling branch January 7, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshsny joshsny joshsny approved these changes

@jonathanlab jonathanlab jonathanlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlesvien @joshsny @jonathanlab