Skip to content

fix: hide electron process from tray #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 1 commit into from
Dec 3, 2025
Merged

fix: hide electron process from tray #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/agent/src/adapters/claude/claude.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,13 @@ export class ClaudeAcpAgent implements Agent {
allowDangerouslySkipPermissions: !IS_ROOT,
permissionMode,
canUseTool: this.canUseTool(sessionId),
// note: although not documented by the types, passing an absolute path
// here works to find zed's managed node version.
executable: process.execPath as any,
// Use "node" to resolve via PATH where a symlink to Electron exists.
// This avoids launching the Electron binary directly from the app bundle,
// which can cause dock icons to appear on macOS even with ELECTRON_RUN_AS_NODE.
executable: "node",
// Prevent spawned Electron processes from showing in dock/tray.
// Must merge with process.env since SDK replaces rather than merges.
env: { ...process.env, ELECTRON_RUN_AS_NODE: "1" },
...(process.env.CLAUDE_CODE_EXECUTABLE && {
pathToClaudeCodeExecutable: process.env.CLAUDE_CODE_EXECUTABLE,
}),
Expand Down Expand Up @@ -986,7 +990,13 @@ export class ClaudeAcpAgent implements Agent {
permissionMode,
canUseTool: this.canUseTool(sessionId),
stderr: (err) => this.logger.error(err),
executable: process.execPath as any,
// Use "node" to resolve via PATH where a symlink to Electron exists.
// This avoids launching the Electron binary directly from the app bundle,
// which can cause dock icons to appear on macOS even with ELECTRON_RUN_AS_NODE.
executable: "node",
// Prevent spawned Electron processes from showing in dock/tray.
// Must merge with process.env since SDK replaces rather than merges.
env: { ...process.env, ELECTRON_RUN_AS_NODE: "1" },
...(process.env.CLAUDE_CODE_EXECUTABLE && {
pathToClaudeCodeExecutable: process.env.CLAUDE_CODE_EXECUTABLE,
}),
Expand Down