Skip to content

fix: Fix compact boundary rendering and type notification params#1224

Merged
charlesvien merged 3 commits intomainfrom
03-12-type_notification_params_instead_of_forwarding_raw_objects
Mar 13, 2026
Merged

fix: Fix compact boundary rendering and type notification params#1224
charlesvien merged 3 commits intomainfrom
03-12-type_notification_params_instead_of_forwarding_raw_objects

Conversation

@charlesvien
Copy link
Member

@charlesvien charlesvien commented Mar 13, 2026

Closes #1218

  1. Fix compact boundaries not rendering after the virtualization upgrade (fixes /compact and auto compact do not render compact boundaries anymore #1218)
  2. Type notification params with explicit interfaces instead of forwarding raw msg.params objects
  3. Mark compacting status spinner as complete when compact_boundary arrives
  4. Fix negative duration shown after force-completed turns

Copy link
Member Author

charlesvien commented Mar 13, 2026

@charlesvien charlesvien force-pushed the 03-12-type_notification_params_instead_of_forwarding_raw_objects branch from 16ce122 to 3536386 Compare March 13, 2026 00:46
@charlesvien charlesvien force-pushed the 03-11-import_and_claude_settings branch from a85657d to 700855b Compare March 13, 2026 00:46
@charlesvien charlesvien changed the title Type notification params instead of forwarding raw objects fix: Fix compact boundary rendering and type notification params Mar 13, 2026
@charlesvien charlesvien marked this pull request as ready for review March 13, 2026 00:48
@charlesvien charlesvien changed the base branch from 03-11-import_and_claude_settings to graphite-base/1224 March 13, 2026 09:54
@charlesvien charlesvien force-pushed the 03-12-type_notification_params_instead_of_forwarding_raw_objects branch from 3536386 to c72b534 Compare March 13, 2026 09:55
@graphite-app graphite-app bot changed the base branch from graphite-base/1224 to main March 13, 2026 09:55
@charlesvien charlesvien force-pushed the 03-12-type_notification_params_instead_of_forwarding_raw_objects branch from c72b534 to d9193ac Compare March 13, 2026 09:55
@charlesvien charlesvien merged commit e322639 into main Mar 13, 2026
15 checks passed
Copy link
Member Author

Merge activity

@charlesvien charlesvien deleted the 03-12-type_notification_params_instead_of_forwarding_raw_objects branch March 13, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/compact and auto compact do not render compact boundaries anymore

2 participants