Skip to content

feat: Scope action selector keyboard events to focused panel#1246

Merged
charlesvien merged 1 commit intomainfrom
03-13-command_center_keyboard_input
Mar 16, 2026
Merged

feat: Scope action selector keyboard events to focused panel#1246
charlesvien merged 1 commit intomainfrom
03-13-command_center_keyboard_input

Conversation

@charlesvien
Copy link
Member

@charlesvien charlesvien commented Mar 14, 2026 •
edited
Loading

  1. Skip keyboard event handling when ActionSelector container is not focused
  2. Add focus ring styling to grid cells on focus-within
  3. Delegate click on grid cell to focus its ActionSelector

@charlesvien Graphite App
Copy link
Member Author

charlesvien commented Mar 14, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 14, 2026
Merged
Merged
@charlesvien charlesvien changed the title Scope action selector keyboard events to focused panel in command center feat: Scope action selector keyboard events to focused panel Mar 14, 2026
@charlesvien charlesvien marked this pull request as ready for review March 14, 2026 21:43
jonathanlab
jonathanlab approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@jonathanlab jonathanlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@charlesvien Graphite App
Copy link
Member Author

charlesvien commented Mar 16, 2026 •
edited
Loading

Merge activity

  • Mar 16, 4:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 16, 4:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 16, 4:24 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 03-14-claude_effort_and_context_window to graphite-base/1246 March 16, 2026 16:08
@charlesvien charlesvien changed the base branch from graphite-base/1246 to main March 16, 2026 16:16
@charlesvien charlesvien force-pushed the 03-13-command_center_keyboard_input branch from 654c65f to 811a455 Compare March 16, 2026 16:17
@charlesvien charlesvien merged commit dd60249 into main Mar 16, 2026
15 checks passed
@charlesvien charlesvien deleted the 03-13-command_center_keyboard_input branch March 16, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanlab jonathanlab jonathanlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charlesvien @jonathanlab