Skip to content

fix: Don't auto-install updates when user quits the app#1255

Merged
tatoalo merged 1 commit intomainfrom
fix/ph-code/no-auto-update-on-quit
Mar 16, 2026
Merged

fix: Don't auto-install updates when user quits the app#1255
tatoalo merged 1 commit intomainfrom
fix/ph-code/no-auto-update-on-quit

Conversation

@tatoalo
Copy link
Contributor

@tatoalo tatoalo commented Mar 16, 2026

when a pending update was downloaded and the user quit, the before-quit handler called quitAndInstall(), restarting the app instead of closing it

squirrel already stages downloaded updates, so the next manual launch applies the update automatically, no restart needed

@tatoalo tatoalo force-pushed the fix/ph-code/no-auto-update-on-quit branch from 7bf183d to b8045ab Compare March 16, 2026 13:01
@tatoalo tatoalo requested a review from a team March 16, 2026 13:03
@charlesvien
Copy link
Member

I can see how this is a conflicting user intent, I want to quit the app not quit and then have it reopen on me because there is an update. I lost context on the original change behind this but if I recall it was not actually updating the app on the next restart, we've done a lot of updates since then tho- happy to merge and if we have reports come in we can handle it in a more graceful way.

@tatoalo tatoalo merged commit 2dbdfd9 into main Mar 16, 2026
14 checks passed
@tatoalo tatoalo deleted the fix/ph-code/no-auto-update-on-quit branch March 16, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants