fix: Don't auto-install updates when user quits the app#1255
Merged
Conversation
7bf183d to
b8045ab
Compare
tatoalo
commented
Mar 16, 2026
Member
|
I can see how this is a conflicting user intent, I want to quit the app not quit and then have it reopen on me because there is an update. I lost context on the original change behind this but if I recall it was not actually updating the app on the next restart, we've done a lot of updates since then tho- happy to merge and if we have reports come in we can handle it in a more graceful way. |
charlesvien
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a pending update was downloaded and the user quit, the
before-quithandler calledquitAndInstall(), restarting the app instead of closing itsquirrelalready stages downloaded updates, so the next manual launch applies the update automatically, no restart needed