Skip to content

Simplify GitHub integration flow#1260

Merged
k11kirky merged 1 commit intomainfrom
03-16-refactor_simplify_github_integration_flow
Mar 16, 2026
Merged

Simplify GitHub integration flow#1260
k11kirky merged 1 commit intomainfrom
03-16-refactor_simplify_github_integration_flow

Conversation

@Twixes
Copy link
Member

@Twixes Twixes commented Mar 16, 2026

Problem

The GitHub integration service had a whole callback server (HTTP in dev, deep links in prod) to detect when the user completed the OAuth flow. This was overly complex and fragile - it managed sockets, timeouts, and HTML responses just to know "did the user click authorize."

Changes

  • Rip out the callback server and deep link machinery from GitHubIntegrationService - now it just opens the authorize URL in the browser and returns immediately
  • Extract shared integration flow schemas into integration-flow-schemas.ts so Linear (and future integrations) can reuse them
  • Update GitIntegrationStep to poll for the integration instead of waiting for a callback
  • Remove the cancelFlow endpoint since there's nothing to cancel anymore

Copy link
Member Author

Twixes commented Mar 16, 2026

@Twixes Twixes changed the title refactor: Simplify GitHub integration flow Simplify GitHub integration flow Mar 16, 2026
@Twixes Twixes marked this pull request as ready for review March 16, 2026 18:01
@k11kirky k11kirky merged commit 50334c2 into main Mar 16, 2026
15 checks passed
@k11kirky k11kirky deleted the 03-16-refactor_simplify_github_integration_flow branch March 16, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants