Skip to content

Comments

chore: Add some scripts and a test console app#21

Merged
haacked merged 5 commits intomasterfrom
haacked/set-up-some-scripts
Apr 16, 2025
Merged

chore: Add some scripts and a test console app#21
haacked merged 5 commits intomasterfrom
haacked/set-up-some-scripts

Conversation

@haacked
Copy link
Contributor

@haacked haacked commented Apr 16, 2025

See RFC https://github.com/PostHog/meta/pull/309/files for some context on these scripts.

The app makes it easier to test some of the changes we're making to the library.

No production changes in this PR

haacked added 3 commits April 16, 2025 13:20
See RFC https://github.com/PostHog/meta/pull/309/files for some context on these scripts.
This makes it easy to test changes while developing this library.
@haacked haacked removed the request for review from rafaeelaudibert April 16, 2025 20:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • examples/.gitignore: Language not supported
  • examples/feature_flag_demo/config/config.exs: Language not supported
  • examples/feature_flag_demo/lib/feature_flag_demo.ex: Language not supported
  • examples/feature_flag_demo/mix.exs: Language not supported
  • examples/feature_flag_demo/run.exs: Language not supported

@haacked haacked requested a review from dmarticus April 16, 2025 20:55
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but there's some references to C#, mind fixing?

@haacked
Copy link
Contributor Author

haacked commented Apr 16, 2025

Lgtm, but there's some references to C#, mind fixing?

Fixed! That's what I get for my copy pasta sins.

@haacked haacked requested a review from rafaeelaudibert April 16, 2025 21:14
@haacked haacked force-pushed the haacked/set-up-some-scripts branch from b7f23e6 to 9407cb1 Compare April 16, 2025 21:19
@rafaeelaudibert
Copy link
Member

Lgtm, but there's some references to C#, mind fixing?

Fixed! That's what I get for my copy pasta sins.

You're forgiven because I got my copy pasta tshirt merch this Monday and it's so so cool

@haacked haacked merged commit 938569f into master Apr 16, 2025
5 checks passed
@haacked haacked deleted the haacked/set-up-some-scripts branch April 16, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants