Fix flaky 1.17 test #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeelaudibert
approved these changes
Oct 1, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Could also enable async on v1.18+ here, wdyt? Approving to see if tests pass
Contributor
Author
|
sorry I didn't get your question 😅 For as long as we have 1.17 tests on CI we'll have to keep those two modules |
Member
|
@martosaur I basically meant: |
Contributor
Author
|
ah yes great call. PR #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I forgot about 1.17, is that it doesn't have
groupfor ExUnit. That's why https://github.com/PostHog/posthog-elixir/actions/runs/18150569276/job/51660693393?pr=56 this is flaky