Conversation
# Conflicts: # CHANGELOG.md # ios/Classes/PosthogFlutterPlugin.swift # lib/src/posthog_flutter_io.dart # test/posthog_flutter_platform_interface_fake.dart
Co-authored-by: Ioannis J <yiannis@posthog.com>
This reverts commit 91cf32f. # Conflicts: # lib/src/posthog_config.dart # lib/src/posthog_flutter_io.dart # test/posthog_flutter_platform_interface_fake.dart
android/src/main/kotlin/com/posthog/flutter/PosthogFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
| case 'showSurvey': | ||
| final Map<String, dynamic> survey = | ||
| Map<String, dynamic>.from(call.arguments); | ||
| final survey = Map<String, dynamic>.from(call.arguments); |
There was a problem hiding this comment.
can we avoid dynamic here, we can change the method signature if needed to use Object or Object?
There was a problem hiding this comment.
I didn't want to touch other code here, hence the ignore_for_file: avoid_dynamic_calls on files that are not part of the PR but should be a simple change yeah
|
btw yesterday I learned about fvm when testing things out. I think it would be nice to add as part of the CI to build against min sdk version |
yep its a popular pm, i'd like to use once we write a proper dart/flutter sdk which supports lin/windows as well instead of only flutter apps on android/ios (and web), so we dont need to depend on the wrapper for everything and works across all supported platforms |
Was just thinking to run the builds against 3.22.0 just to make sure nothing breaks for min |
3 participants
💡 Motivation and Context
Based off original PR here #183
Relates to #81
💚 How did you test it?
📝 Checklist