chore(surveys): enable thumb survey display #257
+186
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
adboio
changed the base branch from
kyle/improve-survey-color-consistency
to
graphite-base/257
adboio
force-pushed
the
graphite-base/257
branch
from
d529a78 to
c739d2f
Compare
adboio
force-pushed
the
01-22-chore_surveys_enable_thumb_survey_display
branch
from
2dfd4c6 to
3a513f6
Compare
adboio
changed the base branch from
graphite-base/257
to
kyle/improve-survey-color-consistency
adboio
force-pushed
the
kyle/improve-survey-color-consistency
branch
from
c739d2f to
1f5f2cf
Compare
adboio
force-pushed
the
01-22-chore_surveys_enable_thumb_survey_display
branch
from
3a513f6 to
0252499
Compare
ioannisj
approved these changes
Jan 23, 2026
Collaborator
There was a problem hiding this comment.
LG. Something that just occurred to me, is the order of the thumbs up/down icons (LTR) intentional? (I see iOS PR does the same, so probably yes) I'm pretty sure I've seen thumbs up on the right in other survey tools, and it also goes against the order of our emoji rating.
ioannisj
requested changes
Jan 23, 2026
Collaborator
ioannisj
left a comment
ioannisj
left a comment
There was a problem hiding this comment.
Just saw there are some build error and CI is not happy, let's address these first
adboio
force-pushed
the
01-22-chore_surveys_enable_thumb_survey_display
branch
from
0252499 to
64933a8
Compare
adboio
force-pushed
the
kyle/improve-survey-color-consistency
branch
from
1f5f2cf to
ae18fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
need to support thumbs up/down to match other SDKs
💚 How did you test it?
📝 Checklist