feat: add xcode dSYM upload script #412
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Dec 16, 2025
| @@ -0,0 +1,84 @@ | |||
| #!/bin/bash | |||
Member
There was a problem hiding this comment.
we should call this with a .sh extension (and give chmod +x permission if not yet)
marandaneto
reviewed
Dec 16, 2025
| exit 0 | ||
| fi | ||
|
|
||
| # Find posthog-cli (Xcode doesn't load shell profiles) |
Member
There was a problem hiding this comment.
are we matching the react native one here?
marandaneto
reviewed
Dec 16, 2025
Comment on lines
+73
to
+82
| # Pass version info from Xcode build settings (overrides plist extraction) | ||
| if [ -n "${PRODUCT_BUNDLE_IDENTIFIER}" ]; then | ||
| CLI_ARGS="$CLI_ARGS --project $PRODUCT_BUNDLE_IDENTIFIER" | ||
| fi | ||
| if [ -n "${MARKETING_VERSION}" ]; then | ||
| CLI_ARGS="$CLI_ARGS --version $MARKETING_VERSION" | ||
| fi | ||
| if [ -n "${CURRENT_PROJECT_VERSION}" ]; then | ||
| CLI_ARGS="$CLI_ARGS --build $CURRENT_PROJECT_VERSION" | ||
| fi |
Member
There was a problem hiding this comment.
we dont do this for the other platforms yet, but we should of course
just wondering if we are passing the right values here since i know the cli used different naming for things such as --project, is that the app namespace? why is it called project?
marandaneto
reviewed
Dec 16, 2025
Comment on lines
+68
to
+71
| # Pass main target dSYM name for accurate version extraction | ||
| if [ -n "${DWARF_DSYM_FILE_NAME}" ]; then | ||
| CLI_ARGS="$CLI_ARGS --main-dsym $DWARF_DSYM_FILE_NAME" | ||
| fi |
Member
There was a problem hiding this comment.
why do we have directory and main-dsym params? why do we have a special main-dsym cmd?
marandaneto
reviewed
Dec 16, 2025
| CLI_ARGS="$CLI_ARGS --main-dsym $DWARF_DSYM_FILE_NAME" | ||
| fi | ||
|
|
||
| # Pass version info from Xcode build settings (overrides plist extraction) |
Member
There was a problem hiding this comment.
why do we need this if the CLI seems to be parsing the info plist already?
Base automatically changed from
feat/error-tracking-manual-capture
to
feat/error-tracking
December 23, 2025 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Adds upload symbols script to be added as an Xcode build phase script
Assumes posthog-cli command from PostHog/posthog#43195
posthog-cli exp dsym upload \ --directory <path> # Directory containing dSYM bundles (required) --main-dsym <filename> # Main target's dSYM name (optional) --project <bundle_id> # App bundle identifier (optional) --version <version> # Marketing version e.g. "3.12.3" (optional) --build <build_number> # Build number e.g. "424" (optional)#skip-changelog
💚 How did you test it?
📝 Checklist