feat: Attempt to use environments for posthog-js deployment#2757
Merged
rafaeelaudibert merged 7 commits intomainfrom Dec 16, 2025
Merged
feat: Attempt to use environments for posthog-js deployment#2757rafaeelaudibert merged 7 commits intomainfrom
rafaeelaudibert merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
.github/workflows/release.yml
Outdated
Comment on lines
+86
to
+95
| - name: Fetch latest main to avoid conflicts | ||
| run: | | ||
| git fetch origin main | ||
| git rebase origin/main || { | ||
| echo "Rebase failed, attempting merge" | ||
| git merge origin/main || { | ||
| echo "Merge also failed. This should not happen in normal operation." | ||
| exit 1 | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
logic: This rebase/merge logic runs after the version bump changes are staged but before committing. If another commit was pushed to main between checkout and this step, the rebase will incorporate those changes into the version bump commit, mixing unrelated changes.
Move this fetch/rebase before the version bump operations (before line 72), or remove it entirely since the concurrency group should prevent simultaneous runs.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 86:95
Comment:
**logic:** This rebase/merge logic runs after the version bump changes are staged but before committing. If another commit was pushed to main between checkout and this step, the rebase will incorporate those changes into the version bump commit, mixing unrelated changes.
Move this fetch/rebase before the version bump operations (before line 72), or remove it entirely since the concurrency group should prevent simultaneous runs.
How can I resolve this? If you propose a fix, please make it concise.| } | ||
| }' | ||
|
|
||
| - name: Dispatch posthog.com upgrade for ${{ matrix.package.name }} |
Contributor
There was a problem hiding this comment.
syntax: Incorrect variable reference - should be matrix.package.name not ${{ matrix.package.name }} in the step name.
Suggested change
| - name: Dispatch posthog.com upgrade for ${{ matrix.package.name }} | |
| - name: Dispatch posthog.com upgrade for posthog-js |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 223:223
Comment:
**syntax:** Incorrect variable reference - should be `matrix.package.name` not `${{ matrix.package.name }}` in the step name.
```suggestion
- name: Dispatch posthog.com upgrade for posthog-js
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Contributor
|
Size Change: 0 B Total Size: 5.26 MB ℹ️ View Unchanged
|
By using the Github app we can skip the requirement for a CodeQL review
By checking main we guarantee we'll see the most recent commits rather than seeing the one from the action HEAD
Piccirello
reviewed
Dec 16, 2025
No need to fail, we'll not proceed anyway
It doesn't make sense to call it deployer because it approves a PR
Piccirello
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanna move our
posthog-js- and all other SDKs eventually - to environments to make sure a maintainer is always approving the workflow. We'll monitor those from Slack.This is an initial attempt to get this to work, let's see how this goes!