fix: posthog-cli finds the correct path on android gradle plugin#2764
Merged
marandaneto merged 4 commits intomainfrom Dec 16, 2025
Merged
fix: posthog-cli finds the correct path on android gradle plugin#2764marandaneto merged 4 commits intomainfrom
marandaneto merged 4 commits intomainfrom
Conversation
Contributor
|
Skipped: No reviewable files found. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Size Change: 0 B Total Size: 5.26 MB ℹ️ View Unchanged
|
marandaneto
commented
Dec 16, 2025
marandaneto
commented
Dec 16, 2025
marandaneto
commented
Dec 16, 2025
marandaneto
commented
Dec 16, 2025
Comment on lines
-35
to
-38
| if [ -n "$POSTHOG_CLI_INSTALL_DIR" ]; then | ||
| PH_CLI_PATH="$POSTHOG_CLI_INSTALL_DIR/posthog-cli" | ||
| elif [ -n "$CARGO_DIST_FORCE_INSTALL_DIR" ]; then | ||
| PH_CLI_PATH="$CARGO_DIST_FORCE_INSTALL_DIR/posthog-cli" |
Member
Author
There was a problem hiding this comment.
those were never used so lets remove them and keep synced with the others
11 tasks
hpouillot
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fix: #2717
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file