-
Notifications
You must be signed in to change notification settings - Fork 220
fix(replay): add targetSessionId to avoid session rotation bugs #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Size Change: +474 B (+0.01%) Total Size: 5.38 MB
ℹ️ View Unchanged
|
f47185a to
d166b8c
Compare
d166b8c to
1429cc1
Compare
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
pauldambra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 🚀
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |

Problem
we're still seeing some instances of session IDs not rotating properly, there seems to be some subtle timing issue that happens some of the time.
Changes
This aims to be more explicit about what sessionID should be used, rather than rely on this.session_id, which is updated at various points in this flow and i suspect can be momentarily out of date?
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file