Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Contributor
|
Size Change: +10.4 kB (+0.17%) Total Size: 5.98 MB
ℹ️ View Unchanged
|
4861997 to
5e0bf5d
Compare
5e0bf5d to
5be468b
Compare
18 tasks
5be468b to
a64545c
Compare
18 tasks
veryayskiy
reviewed
Feb 16, 2026
| enableStrictValidation?: boolean | ||
| } | ||
|
|
||
| export enum ProductTourEventName { |
Contributor
There was a problem hiding this comment.
I'll be @pauldambra and leave this link here: https://www.totaltypescript.com/why-i-dont-like-typescript-enums
Contributor
Author
There was a problem hiding this comment.
i had a colleague at amazon who sent this link to me all the time, i suppose it never stuck and it has come back to haunt me 😆
veryayskiy
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
magic strings and event definitions everywhere!
Changes
moving tour event names / prop names to constants and helper fns
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file