fix(surveys): fix autosubmit bug for hosted surveys#3143
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
378
to
395
| @@ -387,28 +388,29 @@ export class SurveyManager { | |||
| removeSurveyFromFocus={this._removeSurveyFromFocus} | |||
| isPopup={false} | |||
| properties={properties} | |||
| isSurveyCompleted={isSurveyCompleted} | |||
| />, | |||
| selector | |||
| ) | |||
| } | |||
Contributor
There was a problem hiding this comment.
missing early return check that exists in handlePopoverSurvey (lines 204-207). If the survey is completed via URL prefill and has no thank-you message, should we skip rendering entirely?
handlePopoverSurvey has:
if (isSurveyCompleted && !survey.appearance?.displayThankYouMessage) {
return
}consider adding the same check here for consistency, unless hosted surveys intentionally have different behavior
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browser/src/extensions/surveys.tsx
Line: 378-395
Comment:
missing early return check that exists in `handlePopoverSurvey` (lines 204-207). If the survey is completed via URL prefill and has no thank-you message, should we skip rendering entirely?
`handlePopoverSurvey` has:
```typescript
if (isSurveyCompleted && !survey.appearance?.displayThankYouMessage) {
return
}
```
consider adding the same check here for consistency, unless hosted surveys intentionally have different behavior
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Contributor
|
Size Change: +406 B (+0.01%) Total Size: 6.16 MB
ℹ️ View Unchanged
|
lucasheriques
approved these changes
Feb 24, 2026
adboio
deleted the
02-24-fix_surveys_fix_autosubmit_bug_for_hosted_surveys
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hosted surveys do not properly proceed to the confirmation page when they are completed via autofill params
Changes
adds that logic :)
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file