feat(flags): add semver targeting to local evaluation#3186
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Size Change: +9.8 kB (+0.15%) Total Size: 6.66 MB
ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1095
to
+1110
| switch (operator) { | ||
| case 'semver_eq': | ||
| return cmp === 0 | ||
| case 'semver_neq': | ||
| return cmp !== 0 | ||
| case 'semver_gt': | ||
| return cmp > 0 | ||
| case 'semver_gte': | ||
| return cmp >= 0 | ||
| case 'semver_lt': | ||
| return cmp < 0 | ||
| case 'semver_lte': | ||
| return cmp <= 0 | ||
| default: | ||
| throw new InconclusiveMatchError(`Unknown semver operator: ${operator}`) | ||
| } |
Contributor
There was a problem hiding this comment.
The nested switch statement (lines 1095–1110) contains unreachable dead code. The outer case block already constrains operator to one of six semver operators (semver_eq, semver_neq, semver_gt, semver_gte, semver_lt, semver_lte), so the inner switch's default branch can never execute.
Consider restructuring to avoid the nested switch entirely—for example, using a lookup map or individual outer case blocks (as done for semver_tilde, semver_caret, semver_wildcard).
Contributor
There was a problem hiding this comment.
This is legit.
Comment on lines
+1301
to
+1310
| const parsePart = (part: string | undefined): number => { | ||
| if (part === undefined || part === '') { | ||
| return 0 | ||
| } | ||
| const num = parseInt(part, 10) | ||
| if (isNaN(num)) { | ||
| throw new InconclusiveMatchError(`Invalid semver: ${value}`) | ||
| } | ||
| return num | ||
| } |
Contributor
There was a problem hiding this comment.
The parseInt() call in parsePart (line 1305) silently truncates trailing non-numeric characters. For example, parseInt('3alpha', 10) returns 3, not NaN. This means malformed version strings like '1.2.3alpha' (missing the - separator for pre-release) will parse as [1, 2, 3] instead of throwing an InconclusiveMatchError.
Add an explicit digit-only check before parsing:
const parsePart = (part: string | undefined): number => {
if (part === undefined || part === '') {
return 0
}
if (!/^\d+$/.test(part)) {
throw new InconclusiveMatchError(`Invalid semver: ${value}`)
}
const num = parseInt(part, 10)
if (isNaN(num)) {
throw new InconclusiveMatchError(`Invalid semver: ${value}`)
}
return num
}
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
gustavohstrassburger
approved these changes
Mar 4, 2026
Comment on lines
+1095
to
+1110
| switch (operator) { | ||
| case 'semver_eq': | ||
| return cmp === 0 | ||
| case 'semver_neq': | ||
| return cmp !== 0 | ||
| case 'semver_gt': | ||
| return cmp > 0 | ||
| case 'semver_gte': | ||
| return cmp >= 0 | ||
| case 'semver_lt': | ||
| return cmp < 0 | ||
| case 'semver_lte': | ||
| return cmp <= 0 | ||
| default: | ||
| throw new InconclusiveMatchError(`Unknown semver operator: ${operator}`) | ||
| } |
Contributor
There was a problem hiding this comment.
This is legit.
Contributor
There was a problem hiding this comment.
Nice work on the tests.
Contributor
|
Don't forget the release label. |
- Remove unreachable dead code by replacing nested switch with individual case blocks for each semver comparison operator - Add explicit digit-only check in parsePart to reject malformed versions like '1.2.3alpha' (parseInt would silently truncate to 3) - Add test case for malformed version strings with trailing characters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users cannot locally evaluate feature flags that use semver (semantic versioning) property filters. When a flag uses operators like
semver_gtorsemver_caret, the Node SDK must fall back to server-side evaluation, adding latency and requiring network calls.This brings the posthog-node SDK in line with:
user_blast_radiusposthog#44596Changes
matchProperty:semver_eq,semver_neq— equality/inequality comparisonssemver_gt,semver_gte,semver_lt,semver_lte— standard comparisonssemver_tilde— patch-level range (~1.2.3 means >=1.2.3 and <1.3.0)semver_caret— compatible-with range per semver spec (handles 0.x specially)semver_wildcard— wildcard range (1.2.* means >=1.2.0 <1.3.0)parseSemverfunction that:InconclusiveMatchErrorfor invalid inputcomputeTildeBounds,computeCaretBounds,computeWildcardBoundsparseSemverfor testingImplementation notes:
1.2.3-alpha==1.2.3)Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file