Skip to content

fix(replay): do not reject while reading body #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hpouillot merged 1 commit into from
Mar 4, 2026
Merged

fix(replay): do not reject while reading body #3189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/browser/src/extensions/replay/external/network-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,14 +492,14 @@ function _checkForCannotReadResponseBody({
function _tryReadBody(r: Request | Response): Promise<string> {
// there are now already multiple places where we're using Promise...
// eslint-disable-next-line compat/compat
return new Promise((resolve, reject) => {
return new Promise((resolve) => {
const timeout = setTimeout(() => resolve('[SessionReplay] Timeout while trying to read body'), 500)
try {
r.clone()
.text()
.then(
(txt) => resolve(txt),
(reason) => reject(reason)
(reason) => resolve('[SessionReplay] Failed to read body: ' + reason)
)
.finally(() => clearTimeout(timeout))
} catch {
Expand Down
Loading